Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retrieve PDF bulkdata, requesting both octet and pdf #86

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

wayfarer3130
Copy link
Contributor

@wayfarer3130 wayfarer3130 commented Jan 3, 2024

On the bulkdata request, it is permissable to use application/pdf, text/plain, etc for the retrieves when retrieving encapsulated data. This change adds the ability to retrieve the other media types, as well as allowing a fallback option to application/octet-stream.

Previously there was a bug that is you requested retrieveBulkdata, and specifically asked for application/octet-stream it would throw an exception.

Also:
add a debugLog function to allow controlling debugging.
add missing transfer syntaxes for HTJ2K

src/api.js Outdated Show resolved Hide resolved
src/api.js Outdated Show resolved Hide resolved
src/api.js Outdated Show resolved Hide resolved
src/api.js Show resolved Hide resolved
src/api.js Show resolved Hide resolved
Copy link
Contributor

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

src/api.js Show resolved Hide resolved
Copy link
Contributor

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me - not sure about the eslint thing but if you're sure that's correct I'm fine with it.

.eslintrc.js Outdated Show resolved Hide resolved
@wayfarer3130
Copy link
Contributor Author

Everything looks fine to me - not sure about the eslint thing but if you're sure that's correct I'm fine with it

Changed the eslint thing to "always", which is actually the desired behaviour for projects working on both node and browsers, although it has the same affect as setting hte value to 0, just is more desriptive.

@sedghi sedghi merged commit d821e27 into dcmjs-org:master Jan 5, 2024
5 checks passed
Copy link

github-actions bot commented Jan 5, 2024

🎉 This PR is included in version 0.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants