-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Retrieve PDF bulkdata, requesting both octet and pdf #86
fix: Retrieve PDF bulkdata, requesting both octet and pdf #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine to me - not sure about the eslint thing but if you're sure that's correct I'm fine with it.
Changed the eslint thing to "always", which is actually the desired behaviour for projects working on both node and browsers, although it has the same affect as setting hte value to 0, just is more desriptive. |
🎉 This PR is included in version 0.10.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
On the bulkdata request, it is permissable to use application/pdf, text/plain, etc for the retrieves when retrieving encapsulated data. This change adds the ability to retrieve the other media types, as well as allowing a fallback option to application/octet-stream.
Previously there was a bug that is you requested retrieveBulkdata, and specifically asked for application/octet-stream it would throw an exception.
Also:
add a debugLog function to allow controlling debugging.
add missing transfer syntaxes for HTJ2K