Skip to content

Commit

Permalink
feat(core): bump v10.0.0 and dropped @angular/core@9 and earlier
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
DROPPED @angular/core@9 AND EARLIER
If you whant to use @ngxd/core with specific angular version, please install @ngxd/core which version you need:
  @angular/core@7  => npm install @ngxd/core@7
  @angular/core@8  => npm install @ngxd/core@8
  @angular/core@9  => npm install @ngxd/core@9
  @angular/core@10 => npm install @ngxd/core@10
  • Loading branch information
thekiba committed Jul 17, 2020
1 parent b8ace9c commit 81147f4
Show file tree
Hide file tree
Showing 11 changed files with 1,625 additions and 695 deletions.
2,274 changes: 1,598 additions & 676 deletions package-lock.json

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-component-outlet-app",
"version": "9.0.4",
"version": "10.0.0",
"private": true,
"license": "MIT",
"scripts": {
Expand Down Expand Up @@ -53,6 +53,7 @@
"@types/node": "12.12.27",
"codelyzer": "^6.0.0",
"commitizen": "^3.0.7",
"conventional-changelog-cli": "^2.0.34",
"cz-customizable": "^5.2.0",
"hammerjs": "^2.0.8",
"husky": "^1.3.1",
Expand Down
8 changes: 4 additions & 4 deletions projects/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ngxd/core",
"version": "9.0.4",
"version": "10.0.0",
"description": "NGXD is a dynamic pattern + library for Angular",
"keywords": [
"angular",
Expand Down Expand Up @@ -28,9 +28,9 @@
},
"homepage": "https://github.com/IndigoSoft/ngxd",
"peerDependencies": {
"@angular/common": "^6.0.0-rc.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0",
"@angular/core": "^6.0.0-rc.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0",
"rxjs": ">=6.0.0 || ^5.6.0-forward-compat.4"
"@angular/common": "^10.0.0",
"@angular/core": "^10.0.0",
"rxjs": ">=6.0.0"
},
"dependencies": {
"tslib": "^2.0.0"
Expand Down
12 changes: 9 additions & 3 deletions projects/core/src/testing/test-case/operations/operation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,33 @@ import {
} from '../test-case.interfaces';
import { LIFECYCLE_REPORTS } from '../reports/index';

interface TestComponent {
component: object;
name: string;
label: string;
}

export class Operation extends Executable {
private reports: LifecycleReport[] = LIFECYCLE_REPORTS;

constructor(protected operations: Executable[]) {
super();
}

execute<TComponent>(fixture: ComponentFixture<TComponent>) {
execute<TComponent extends TestComponent>(fixture: ComponentFixture<TComponent>) {
this.operations.forEach(operation => operation.execute(fixture));
fixture.detectChanges();
this.expect(fixture);
}

report<TComponent>(oldState: TestCaseState): TestCaseState {
report<TComponent extends TestComponent>(oldState: TestCaseState): TestCaseState {
const newState = this.operations.reduce((acc, operation) => operation.report(acc), oldState);
const report = this.makeReport(oldState, newState);

return { ...newState, lifecycle: [...oldState.lifecycle, ...report] };
}

private expect<TComponent extends any>(fixture: ComponentFixture<TComponent>) {
private expect<TComponent extends TestComponent>(fixture: ComponentFixture<TComponent>) {
const content: string = fixture.nativeElement.innerHTML;
const component: TComponent = fixture.componentInstance;

Expand Down
4 changes: 2 additions & 2 deletions projects/forms/ng-package.prod.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "../../dist/lib",
"dest": "../../dist/forms",
"lib": {
"entryFile": "src/public_api.ts"
}
}
}
8 changes: 4 additions & 4 deletions projects/forms/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ngxd/forms",
"version": "0.1.9000",
"version": "0.1.10000",
"description": "NGXD is a dynamic pattern + library for Angular",
"keywords": [
"angular",
Expand Down Expand Up @@ -28,9 +28,9 @@
},
"homepage": "https://github.com/IndigoSoft/ngxd",
"peerDependencies": {
"@angular/common": "^6.0.0-rc.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0",
"@angular/core": "^6.0.0-rc.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0",
"@angular/forms": "^6.0.0-rc.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0"
"@angular/common": "^10.0.0",
"@angular/core": "^10.0.0",
"@angular/forms": "^10.0.0"
},
"dependencies": {
"tslib": "^2.0.0"
Expand Down
3 changes: 2 additions & 1 deletion projects/forms/tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"fullTemplateTypeCheck": true,
"strictInjectionParameters": true,
"flatModuleId": "AUTOGENERATED",
"flatModuleOutFile": "AUTOGENERATED"
"flatModuleOutFile": "AUTOGENERATED",
"enableIvy": false
},
"exclude": [
"src/test.ts",
Expand Down
2 changes: 1 addition & 1 deletion src/app/containers/benchmark/benchmark.routing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ import { BenchmarkPageComponent } from './benchmark.component';

const routes: Route[] = [{ path: '', component: BenchmarkPageComponent }];

export const BenchmarkRouting: ModuleWithProviders = RouterModule.forChild(routes);
export const BenchmarkRouting: ModuleWithProviders<RouterModule> = RouterModule.forChild(routes);
2 changes: 1 addition & 1 deletion src/app/containers/entities/entities.routing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ import { EntitiesPageComponent } from './entities.component';

const routes: Route[] = [{ path: '', component: EntitiesPageComponent }];

export const EntitiesRouting: ModuleWithProviders = RouterModule.forChild(routes);
export const EntitiesRouting: ModuleWithProviders<RouterModule> = RouterModule.forChild(routes);
2 changes: 1 addition & 1 deletion src/app/containers/lazy/lazy.routing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ import { LazyPageComponent } from './lazy.component';

const routes: Route[] = [{ path: '', component: LazyPageComponent }];

export const LazyRouting: ModuleWithProviders = RouterModule.forChild(routes);
export const LazyRouting: ModuleWithProviders<RouterModule> = RouterModule.forChild(routes);
2 changes: 1 addition & 1 deletion src/app/containers/table/table.routing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ import { TablePageComponent } from './table.component';

const routes: Route[] = [{ path: '', component: TablePageComponent }];

export const TableRouting: ModuleWithProviders = RouterModule.forChild(routes);
export const TableRouting: ModuleWithProviders<RouterModule> = RouterModule.forChild(routes);

0 comments on commit 81147f4

Please sign in to comment.