-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dbt-assertions
package to hub
#301
Conversation
Update for a generic test and better documentation in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wildly cool, I love it 🤩
Two comments:
- now that this will be on the hub, please update the readme's sample code to a hub reference instead of installing directly from git
- the dbt-assertions image header is clever, but I think it runs afoul of our trademark guidelines as it's "combined with another logo". Can you also update that?
ty!
Oh my bad, let me change this during the day. I though it was a good idea but you're right Thank you for the feedback I return to you as fast as possible |
What about this image if I keep the |
Thanks for the quick turnaround @AxelThevenot! I have checked internally, and the takeaway is that you can't use the logo at all - the relevant part of the trademark guidelines is:
However you could do something like this: (as long as the word mark includes the ™, which your current version does) or use the name
Hopefully that makes sense - lmk if not, either here or |
Everything is now updated (image and install) |
YAY I am so excited to take this for a spin! |
You'll tell me :) I have an other package I create the PR |
Description
Link to your package's repository: https://github.com/AxelThevenot/dbt-assertions
Checklist
This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.
First run experience
Customisability
Packages for data transformation (delete if not relevant):
Dependencies
Dependencies on dbt Core
require-dbt-version
range indbt_project.yml
. Example: A package which depends on functionality added in dbt Core 1.2 should set itsrequire-dbt-version
property to[">=1.2.0", "<2.0.0"]
.Dependencies on other packages defined in packages.yml:
Interoperability
{{ dbt.except() }}
and{{ dbt.type_string() }}
.users
.Versioning