Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/performance reviews update (RSC 5.6.2024) #103

Merged
merged 4 commits into from
May 6, 2024

Conversation

r-scardoso
Copy link

Edits to our Performance Review Cycle as requested by Annie Brown

@r-scardoso r-scardoso requested a review from leighstaub May 6, 2024 21:06
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
handbook-getdbt-com ✅ Ready (Inspect) Visit Preview May 6, 2024 9:06pm

@r-scardoso r-scardoso merged commit e428731 into main May 6, 2024
8 checks passed
@r-scardoso
Copy link
Author

@leighstaub - for some reason the image is not displaying correctly 😢 Any chance you know why? I checked my work and edits on the back end under preview and it's showing correctly. 🤔 Not sure why it doesn't show up in the live version. Any thoughts? Attaching screenshots for reference:

Screenshot 2024-05-06 at 5 49 13 PM Screenshot 2024-05-06 at 5 47 52 PM Screenshot 2024-05-06 at 5 46 09 PM Screenshot 2024-05-06 at 5 45 46 PM Screenshot 2024-05-06 at 5 06 22 PM


#### Performance Definitions
![IMAGE](https://github.com/dbt-labs/handbook/blob/346a90fa6993732528a78c44aea15b988eb66a58/website/static/img/PR%20Update%202024.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r-scardoso @john-rock ! if this is anything like our docs site, is it that you need to save the image here first and then reference the image under the #### header? but I'm not sure how to reference it ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mirnawong1 that was going to be my first suggestion!

@r-scardoso can you adjust the link to the image so that it is a direct link to the file
e.g.
![IMAGE](/website/static/img/PR%20Update%202024.png)

If that doesn't work my next suggestion would be re-uploading the image with no spaces in the file name. Sometimes Vercel can be picky when it comes to spaces and/or uppercase letters in the file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants