Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dremio-setup.md #6837

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Update dremio-setup.md #6837

merged 2 commits into from
Jan 29, 2025

Conversation

AndyHunt66
Copy link
Contributor

@AndyHunt66 AndyHunt66 commented Jan 28, 2025

The sentence
"See Support Keys in the Dremio documentation for the steps." makes no sense in this context. There is nothing on this page that requires the setting of a support key, apart from if you're using a PAT and haven't yet set up your Dremio system to use PATs, and even then, the wrong page is linked to.

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines. Not version specific
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page. No RN required

The sentence 
"See Support Keys in the Dremio documentation for the steps." makes no sense in this context. There is nothing on this page that requires the setting of a support key, apart from if you're using a PAT and haven't yet set up your Dremio system to use PATs, and even then, the wrong page is linked to.
@AndyHunt66 AndyHunt66 requested a review from a team as a code owner January 28, 2025 13:16
Copy link

welcome bot commented Jan 28, 2025

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 28, 2025

@AndyHunt66 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 28, 2025
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 28, 2025
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @AndyHunt66 , thanks for opening this up and great catch! based on this pr https://github.com/dbt-labs/docs.getdbt.com/pull/6689/files, it looks like line 40 was missed since support keys aren't required anymore. thanks for catching and opening this up! ✨

@mirnawong1 mirnawong1 merged commit 41d6c23 into dbt-labs:current Jan 29, 2025
3 of 5 checks passed
@AndyHunt66 AndyHunt66 deleted the patch-1 branch January 29, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants