-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarifies mf timespine & creates mini guide #6836
base: current
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
5. Double check that the results are correct and returning the expected data. | ||
|
||
## Add additional granularities (optional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we could do this based on this example but when i tested it, it only returned date_day.
|
||
4. Validate the output by querying the generated table: | ||
```bash | ||
dbt sl query --metrics revenue --group-by metric_time__hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the ide doesn't support metric_time__hour
-- is this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or should i scrap this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think the IDE supports metric_time__hour
, why do you say otherwise?
You could try
dbt sl list dimensions --metrics revenue
|
||
4. Validate the output by querying the generated table: | ||
```bash | ||
dbt sl query --metrics revenue --group-by metric_time__hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think the IDE supports metric_time__hour
, why do you say otherwise?
You could try
dbt sl list dimensions --metrics revenue
Should a mini guide include custom time spines / custom calendars? |
Co-authored-by: Pat Kearns <[email protected]>
Co-authored-by: Pat Kearns <[email protected]>
|
||
## Run and test the time spine | ||
|
||
For the time spine table you created, let's run it and validate the output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patkearns10 , i think maybe lines 133-143 dont make sense. i probably should just start with 144, query dbt sl query --metrics revenue --group-by metric_time
-- does that make sense to you in terms of how to test the .sql and yaml file work?
this pr clarifies that that the MF timespine doc based on user feedback in community slack.
PR clarifies that:
🚀 Deployment available! Here are the direct links to the updated files: