Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sl rn saved queries w no exports #6798

Merged
merged 3 commits into from
Jan 20, 2025
Merged

sl rn saved queries w no exports #6798

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e40170
saved-queries-exports-rn
mirnawong1 Jan 20, 2025
1463e1a
Update website/docs/docs/dbt-versions/release-notes.md
mirnawong1 Jan 20, 2025
a615e5f
Update website/docs/docs/dbt-versions/release-notes.md
mirnawong1 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/docs/docs/dbt-versions/release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ dbt Cloud release notes for recent and historical changes. Release notes fall in

Release notes are grouped by month for both multi-tenant and virtual private cloud (VPC) environments.


## January 2025

- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports don't fail.
Copy link
Contributor

@nataliefiann nataliefiann Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports don't fail.
- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error, due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports, don't fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nataliefiann ! not sure if we need the commas here and i wonder if it actually disrupts the flow. the clause "don't fail" is directly linked to the preceding phrase so it looks like the comma interrupts it. how about adding a comma after the 'Exports are optional, and this...:

Copy link
Contributor Author

@mirnawong1 mirnawong1 Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to commit it with the: 'Exports are optional, and this...' but please let me know if you have any strong feelings about this version! thank yoU!

mirnawong1 marked this conversation as resolved.
Show resolved Hide resolved
- **New**: You can now query metric alias in dbt Semantic Layer [GraphQL](/docs/dbt-cloud-apis/sl-graphql) and [JDBC](/docs/dbt-cloud-apis/sl-jdbc) APIs.
- For the JDBC API, refer to [Query metric alias](/docs/dbt-cloud-apis/sl-jdbc#query-metric-alias) for more information.
- For the GraphQL API, refer to [Query metric alias](/docs/dbt-cloud-apis/sl-graphql#query-metric-alias) for more information.
Expand Down
Loading