updated according to dbt-teradata 1.8.2 #6577
Open
+43
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tallamohan is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
content
mirnawong1
reviewed
Dec 9, 2024
mirnawong1
reviewed
Dec 9, 2024
Co-authored-by: Mirna Wong <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Mirna Wong <[email protected]>
|
looping in @amychen1776 as an fyi |
mirnawong1
reviewed
Dec 13, 2024
mirnawong1
reviewed
Dec 13, 2024
mirnawong1
reviewed
Dec 13, 2024
| @@ -241,6 +247,14 @@ dbt-teradata 1.8.0 and later versions support unit tests, enabling you to valida | |||
|
|
|||
| ## Limitations | |||
|
|
|||
| ### Browser Authentication | |||
| When running a dbt job with logmech set to "browser", the initial authentication opens a browser window where you must enter your username and password.<br> | |||
There was a problem hiding this comment.
@tallamohan can you turn these into bullets and remove the
. so:
- When running a dbt job with logmech set to "browser", the initial authentication opens a browser window where you must enter your username and password.
- After authentication, this window remains open, requiring you to manually switch back to the dbt console.
- For every subsequent connection, a new browser tab briefly opens, displaying the message "TERADATA BROWSER AUTHENTICATION COMPLETED," and silently reuses the existing session.
- However, the focus stays on the browser window, so you’ll need to manually switch back to the dbt console each time.
- This behavior is the default functionality of the teradatasql driver and cannot be avoided at this time.
- To prevent session expiration and the need to re-enter credentials, ensure the authentication browser window stays open until the job is complete.
mirnawong1
reviewed
Dec 13, 2024
mirnawong1
reviewed
Dec 13, 2024
mirnawong1
reviewed
Dec 13, 2024
| * Identify and adjust overlapping time slices: | ||
| * Overlapping time periods in the data are detected and corrected to maintain a consistent and non-overlapping timeline. | ||
| * Manage records needing to be overwritten or split based on the source and target data: | ||
| * The process of removing primary key duplicates (ie. two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model) is retained. Full-row duplicates are always de-duplicated. |
There was a problem hiding this comment.
Suggested change
| * The process of removing primary key duplicates (ie. two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model) is retained. Full-row duplicates are always de-duplicated. | |
| * The process of removing primary key duplicates (two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model). Full-row duplicates are always de-duplicated. |
mirnawong1
reviewed
Dec 13, 2024
| * The process of removing primary key duplicates (ie. two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model) is retained. Full-row duplicates are always de-duplicated. | ||
| * Identify and adjust overlapping time slices (if use_valid_to_time='yes): | ||
| * Overlapping time periods in the data are corrected to maintain a consistent and non-overlapping timeline. To do so, the valid period end bound of a record is adjusted to meet the begin bound of the next record with the same `unique_key` value and overlapping `valid_period` value if any. | ||
| * Manage records needing to be adjusted, deleted or split based on the source and target data: |
There was a problem hiding this comment.
Suggested change
| * Manage records needing to be adjusted, deleted or split based on the source and target data: | |
| * Manage records needing to be adjusted, deleted, or split based on the source and target data: |
mirnawong1
reviewed
Dec 13, 2024
mirnawong1
reviewed
Dec 13, 2024
There was a problem hiding this comment.
hey @tallamohan , thanks for opening this pr up! i've made some suggestions adn couldn't commit them myself unfortunately. could you make those changes on your end and when it's ready, give me a tag and i'll look it over again?
amychen1776
reviewed
Dec 13, 2024
| For every subsequent connection, a new browser tab briefly opens, displaying the message "TERADATA BROWSER AUTHENTICATION COMPLETED," and silently reuses the existing session.<br> | ||
| However, the focus stays on the browser window, so you’ll need to manually switch back to the dbt console each time.<br> | ||
| This behavior is the default functionality of the teradatasql driver and cannot be avoided at this time.<br> | ||
| To prevent session expiration and the need to re-enter credentials, ensure the authentication browser window stays open until the job is complete. |
There was a problem hiding this comment.
This is not a great user experience. Do you have plans to provide caching and if so, can it be called out?
There was a problem hiding this comment.
The engineering team responsible for the teradatasql driver is actively working to resolve this issue. Currently, there is no estimated time of arrival (ETA) for the fix.
amychen1776
reviewed
Dec 13, 2024
| @@ -95,7 +95,6 @@ Parameter | Default | Type | Description | |||
| `browser_tab_timeout` | `"5"` | quoted integer | Specifies the number of seconds to wait before closing the browser tab after Browser Authentication is completed. The default is 5 seconds. The behavior is under the browser's control, and not all browsers support automatic closing of browser tabs. | |||
| `browser_timeout` | `"180"` | quoted integer | Specifies the number of seconds that the driver will wait for Browser Authentication to complete. The default is 180 seconds (3 minutes). | |||
| `column_name` | `"false"` | quoted boolean | Controls the behavior of cursor `.description` sequence `name` items. Equivalent to the Teradata JDBC Driver `COLUMN_NAME` connection parameter. False specifies that a cursor `.description` sequence `name` item provides the AS-clause name if available, or the column name if available, or the column title. True specifies that a cursor `.description` sequence `name` item provides the column name if available, but has no effect when StatementInfo parcel support is unavailable. | |||
| `connect_failure_ttl` | `"0"` | quoted integer | Specifies the time-to-live in seconds to remember the most recent connection failure for each IP address/port combination. The driver subsequently skips connection attempts to that IP address/port for the duration of the time-to-live. The default value of zero disables this feature. The recommended value is half the database restart time. Equivalent to the Teradata JDBC Driver `CONNECT_FAILURE_TTL` connection parameter. | |||
There was a problem hiding this comment.
Did you remove this functionality? If so it might be worth calling that out to avoid confusion
There was a problem hiding this comment.
Yes, this functionality is not more supported. Hence removed from the list.
mirnawong1
reviewed
Jan 9, 2025
There was a problem hiding this comment.
hey @tallamohan, wanted to check in to see if you had any questions on our reviews? many thanks!
|
@mirnawong1 , Thanks for your patience. I am back from the vacation. Will address the review command and make the changes ASAP. Moreover, we have released dbt-teradata 1.9.0 recently. I will be making those changes also in the PR. Thanks |
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
amychen1776
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Updated the setup and config pages of dbt-teradata according to the latest release dbt-teradata 1.8.2