Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warnings.md #5434

Merged
merged 21 commits into from
May 9, 2024
Merged

Update warnings.md #5434

merged 21 commits into from
May 9, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented May 2, 2024

Link to staging

Resolves #5417 for v1.8

adds warn.silence to the warnings doc in prep for v1.8

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Resolves #5417 for v1.8

adds warn.silence to the warnings doc in prep for v1.8
@mirnawong1 mirnawong1 added this to the dbt Core v1.8 Documentation milestone May 2, 2024
@mirnawong1 mirnawong1 requested a review from a team as a code owner May 2, 2024 16:50
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:33pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels May 2, 2024
@runleonarun
Copy link
Collaborator

runleonarun commented May 7, 2024

@QMalcolm and @graciegoheen How should we document this change? This PR versions include/exclude for 1.7 and prior. We versioned warn/error/silence for 1.8 and higher.

Let me know if you'd prefer this handled differently because include/exclude can still be used in 1.8+ (from what I can tell in the PR notes.)

@QMalcolm
Copy link
Contributor

QMalcolm commented May 7, 2024

@QMalcolm and @graciegoheen How should we document this change? This PR versions include/exclude for 1.7 and prior. We versioned warn/error/silence for 1.8 and higher.

Let me know if you'd prefer this handled differently because include/exclude can still be used in 1.8+ (from what I can tell in the PR notes.)

I think moving to the language of warn/error/silence for 1.8+ makes sense! The old keys exclude/include will still work, and they haven't technically been deprecated (though I can imagine a future where we do deprecate them). However, I think we probably want to be opinionated and get people slowly moved over.

All that said, I would defer to @graciegoheen as I think her perspective is more important here.

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to ship from docs perspective.

@runleonarun
Copy link
Collaborator

@Grace when you're ready to review, here's the staging link!

@graciegoheen
Copy link
Collaborator

I agree with Quigley here - let's use the new warn/error/silence language for 1.8+

@matthewshaver matthewshaver self-assigned this May 9, 2024
@matthewshaver matthewshaver enabled auto-merge May 9, 2024 15:31
@matthewshaver matthewshaver merged commit a428772 into current May 9, 2024
10 checks passed
@matthewshaver matthewshaver deleted the mirnawong1-patch-29 branch May 9, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Changes Needed from dbt-core Issue #9644
5 participants