-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warnings.md #5434
Update warnings.md #5434
Conversation
Resolves #5417 for v1.8 adds warn.silence to the warnings doc in prep for v1.8
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
update versions
@QMalcolm and @graciegoheen How should we document this change? This PR versions include/exclude for 1.7 and prior. We versioned warn/error/silence for 1.8 and higher. Let me know if you'd prefer this handled differently because include/exclude can still be used in 1.8+ (from what I can tell in the PR notes.) |
I think moving to the language of All that said, I would defer to @graciegoheen as I think her perspective is more important here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to ship from docs perspective.
@Grace when you're ready to review, here's the staging link! |
I agree with Quigley here - let's use the new |
Link to staging
Resolves #5417 for v1.8
adds warn.silence to the warnings doc in prep for v1.8
What are you changing in this pull request and why?
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pages