Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sl-jdbc.md #4102

Merged
merged 19 commits into from
Oct 13, 2023
Merged

Update sl-jdbc.md #4102

merged 19 commits into from
Oct 13, 2023

Conversation

rpourzand
Copy link
Contributor

Draft PR

We now allow Dimension() to be used in a where clause for a time dimension (as opposed to TimeDimension ()). This matches the GROUP BY syntax.

We now have a way to use Order By when you are ordering by a dimension you operated on.

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@rpourzand rpourzand requested a review from a team as a code owner September 20, 2023 22:51
@vercel
Copy link

vercel bot commented Sep 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 10:22am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Sep 20, 2023
@rpourzand
Update sl-jdbc.md
1cc4c03 
fixing typo
rpourzand and others added 2 commits September 22, 2023 10:41
@rpourzand @mirnawong1
Update website/docs/docs/dbt-cloud-apis/sl-jdbc.md
438568b 
Co-authored-by: mirnawong1 <[email protected]>
@rpourzand
Update sl-jdbc.md
85f1772 
Changing wording per Devon's recommendation
mirnawong1
mirnawong1 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rpourzand , lgtm!

@github-actions github-actions bot added the guides Knowledge best suited for Guides label Oct 2, 2023
@mirnawong1
Copy link
Contributor

hey ya'll happy to merge this if this is good to go?

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Oct 2, 2023
@mirnawong1
Copy link
Contributor

Don't merge yet per Roxi

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Oct 13, 2023
@mirnawong1 mirnawong1 enabled auto-merge October 13, 2023 09:56
@mirnawong1 mirnawong1 disabled auto-merge October 13, 2023 09:56
@mirnawong1 mirnawong1 enabled auto-merge October 13, 2023 10:00
@mirnawong1 mirnawong1 merged commit 6cccc16 into current Oct 13, 2023
@mirnawong1 mirnawong1 deleted the rpourzand-order-by-and-where-updates branch October 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevonFulcher DevonFulcher DevonFulcher approved these changes

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content do not merge guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpourzand @mirnawong1 @DevonFulcher