Removes duplicate version of the prism-react-renderer #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size: x-small
|
✔️ Deploy Preview for docs-getdbt-com ready! 🔨 Explore the source changes: 1926527 🔍 Inspect the deploy log: https://app.netlify.com/sites/docs-getdbt-com/deploys/61f43ba6429708000776a041 😎 Browse the preview: https://deploy-preview-1063--docs-getdbt-com.netlify.app |
lfracalossiFA
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Asana task: https://app.asana.com/0/1200099998847559/1201682203530869/f
Snyk flagged an outdated PrismJS package. This package is being used by the prism-react-renderer package, which is included in Docusaurus. While we are unable to edit the dependency used by the Docusaurus theme, I noticed the package in our package.json is unneeded, as it is already included in Docusaurus. This removes prism-react-renderer from our package.json, which looks like it was added when I initially upgraded Docusaurus.
Note, I do not expect this to correct the Snyk flag, as the outdated package is still used by Docusaurus. There is an open Git issue here, and noted by Docusaurus here.
Pre-release docs
Is this change related to an unreleased version of dbt?
next<Changelog>[New/Changed] in v0.x.0</Changelog>currentPreview
This is used for CodeBlock components, which are used on our /styles page. To test, we want to verify the CodeBlocks are still working.
https://deploy-preview-1063--docs-getdbt-com.netlify.app/styles