Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import statement for --empty tests #258

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

Problem

When tests were copied over from dbt-snowflake into dbt-tests-adapter, the relative import for models was not updated.

Solution

Fix the import statement.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 3, 2024
@mikealfare mikealfare requested a review from a team as a code owner July 3, 2024 20:35
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare added the Skip Changelog Skip changelog verification in a PR label Jul 3, 2024
@mikealfare mikealfare merged commit 7e9731c into main Jul 3, 2024
15 of 17 checks passed
@mikealfare mikealfare deleted the fix-empty-tests-import branch July 3, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA Skip Changelog Skip changelog verification in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] --empty flag generates invalid SQL when running adapter.get_columns_in_relation
2 participants