Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC'24 Amharic chapter] Extend Existing Extractors For Amharic #766

Merged

Conversation

Meti-Adane
Copy link
Contributor

  • Added Amharic configurations to extend existing extractors
  • Added associated tests
  • Included extended extractors in property files

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Human facing. Small stuff.

Copy link
Member

@jimkont jimkont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, we should also incorporate @TallTed 's documentation suggestions

Meti-Adane and others added 2 commits September 8, 2024 16:31
…eIntervalMappingConfig.scala

Co-authored-by: Ted Thibodeau Jr <[email protected]>
…arserUtilsConfig.scala

Co-authored-by: Ted Thibodeau Jr <[email protected]>
Copy link

sonarqubecloud bot commented Sep 8, 2024

@jimkont jimkont merged commit eae38fb into dbpedia:master Dec 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants