Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove obsolete variable #3652

Merged
merged 1 commit into from
Jan 8, 2025
Merged

refactor: remove obsolete variable #3652

merged 1 commit into from
Jan 8, 2025

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Jan 8, 2025 •
edited
Loading

Proposed changes

These variables have been used in our SCSS code previously but we won't need them at the moment.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jan 8, 2025
@mfranzke mfranzke self-assigned this Jan 8, 2025
@mfranzke mfranzke removed their assignment Jan 8, 2025
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-remove-obsolete-variable

@mfranzke mfranzke enabled auto-merge (squash) January 8, 2025 13:20
@mfranzke mfranzke disabled auto-merge January 8, 2025 14:06
@mfranzke mfranzke merged commit fd36948 into main Jan 8, 2025
74 checks passed
@mfranzke mfranzke deleted the refactor-remove-obsolete-variable branch January 8, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏗foundations Changes inside foundations folder 🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfranzke