Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend letterbox behavior #2899

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Conversation

arrufat
Copy link
Contributor

@arrufat arrufat commented Dec 6, 2023

Before it required to specify a size and would perform a square letterbox.

I think it's better if we make the input image fit into the shape of the output image.
Moreover, that makes the function never allocate the output image.

@arrufat
Copy link
Contributor Author

arrufat commented Dec 6, 2023

I know this is a breaking change... Let's see if the tests pass and if we need to provide the old interface, too.

@davisking davisking merged commit 19a952c into davisking:master Dec 8, 2023
9 of 10 checks passed
@davisking
Copy link
Owner

Cool, yeah this is better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants