fix #596: make layout_summary() layout order correspond to order in PPTX file #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In class `dir_collection`, files are added to a container during initialization using alphabetical sorting. This caused the slide layout order to deviate from the one in the PPTX file, for example, when calling layout_summary(). Files are now added to a container in the order of their trailing numeric index. For example, `slideLayout2.xml` will now preceed `slideLayout10.xml`. Before, alphabetical sorting was used, where `slideLayout10.xml` comes before `slideLayout2.xml`.
|
thanks a lot for your work ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #596. All tests are passed. Coverage of new functions is 100%.
Changes
The layout order in
layout_summary()now corresponds to the layout order in the PPTX file, also in case of multiple masters.Technical
In class
dir_collection, the files are now added to a container in the order of their trailing numeric index. For example,slideLayout2.xmlwill now preceedslideLayout10.xml. Before, alphabetical sorting was used, whereslideLayout10.xmlcomes beforeslideLayout2.xml.