tests: drop some visual testing

davidgohel · Oct 27, 2024 · 040e39c · 040e39c
1 parent 71b7716
commit 040e39c
Show file tree

Hide file tree

Showing 11 changed files with 19 additions and 38 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: officedown
 Type: Package
 Title: Enhanced 'R Markdown' Format for 'Word' and 'PowerPoint'
-Version: 0.3.3
+Version: 0.4.0.001
 Authors@R: c(
     person("David", "Gohel", role = c("aut", "cre", "cph"),
     email = "[email protected]"),

diff --git a/tests/testthat/_snaps/rdocx-plots/plot-basic.png b/tests/testthat/_snaps/rdocx-plots/plot-basic.png
diff --git a/tests/testthat/_snaps/rpptx/pptx-example.png b/tests/testthat/_snaps/rpptx/pptx-example.png
diff --git a/tests/testthat/utils.R → tests/testthat/helper-utils.R b/tests/testthat/utils.R → tests/testthat/helper-utils.R
@@ -4,9 +4,9 @@ render_rmd <- function(rmd_file, output_file) {
   tryCatch(
     {
       rmarkdown::render(rmd_file,
-             output_file = output_file,
-             envir = new.env(),
-             quiet = TRUE
+        output_file = output_file,
+        envir = new.env(),
+        quiet = TRUE
       )
       sucess <- TRUE
     },

diff --git a/tests/testthat/test-rdocx-lists.R b/tests/testthat/test-rdocx-lists.R
@@ -5,8 +5,6 @@ library(rmarkdown)
 skip_if_not(rmarkdown::pandoc_available())
 skip_if_not(pandoc_version() >= numeric_version("2"))
 
-source("utils.R")
-
 docx_file <- tempfile(fileext = ".docx")
 render_rmd("rmd/lists.Rmd", output_file = docx_file)
 

diff --git a/tests/testthat/test-rdocx-par-settings.R b/tests/testthat/test-rdocx-par-settings.R
@@ -5,8 +5,6 @@ library(rmarkdown)
 skip_if_not(rmarkdown::pandoc_available())
 skip_if_not(pandoc_version() >= numeric_version("2"))
 
-source("utils.R")
-
 docx_file <- tempfile(fileext = ".docx")
 render_rmd("rmd/par-settings.Rmd", output_file = docx_file)
 

diff --git a/tests/testthat/test-rdocx-plots.R b/tests/testthat/test-rdocx-plots.R
@@ -5,14 +5,11 @@ library(rmarkdown)
 skip_if_not(rmarkdown::pandoc_available())
 skip_if_not(pandoc_version() >= numeric_version("2"))
 
-source("utils.R")
-
+docx_file <- tempfile(fileext = ".docx")
+render_rmd("rmd/plot-basic.Rmd", output_file = docx_file)
 
 test_that("reading captions", {
 
-  docx_file <- tempfile(fileext = ".docx")
-  render_rmd("rmd/plot-basic.Rmd", output_file = docx_file)
-
   node_body <- get_docx_xml(docx_file)
 
   expect_equal(
@@ -24,13 +21,3 @@ test_that("reading captions", {
     "Figure SEQ fig \\* Arabic: What a barplot"
   )
 })
-
-test_that("visual testing plots", {
-  testthat::skip_if_not_installed("doconv")
-  testthat::skip_if_not(doconv::msoffice_available())
-  library(doconv)
-  docx_file <- tempfile(fileext = ".docx")
-  render_rmd("rmd/plot-basic.Rmd", output_file = docx_file)
-
-  expect_snapshot_doc(x = docx_file, name = "plot-basic", engine = "testthat")
-})
diff --git a/tests/testthat/test-rdocx-sections.R b/tests/testthat/test-rdocx-sections.R
@@ -7,8 +7,6 @@ skip_on_cran()
 skip_if_not(rmarkdown::pandoc_available())
 skip_if_not(pandoc_version() >= numeric_version("2"))
 
-source("utils.R")
-
 docx_file <- tempfile(fileext = ".docx")
 render_rmd("rmd/sections.Rmd", output_file = docx_file)
 

diff --git a/tests/testthat/test-rdocx-tables.R b/tests/testthat/test-rdocx-tables.R
@@ -5,8 +5,6 @@ library(rmarkdown)
 skip_if_not(rmarkdown::pandoc_available())
 skip_if_not(pandoc_version() >= numeric_version("2"))
 
-source("utils.R")
-
 docx_file <- tempfile(fileext = ".docx")
 render_rmd("rmd/tables-basic.Rmd", output_file = docx_file)
 

diff --git a/tests/testthat/test-render-r.R b/tests/testthat/test-render-r.R
@@ -4,8 +4,6 @@ library(rmarkdown)
 skip_if_not(rmarkdown::pandoc_available())
 skip_if_not(pandoc_version() >= numeric_version("2"))
 
-source("utils.R")
-
 str <- c(
   "#' ---",
   "#' output: officedown::rdocx_document",

diff --git a/tests/testthat/test-rpptx.R b/tests/testthat/test-rpptx.R
@@ -5,15 +5,19 @@ library(rmarkdown)
 skip_if_not(rmarkdown::pandoc_available())
 skip_if_not(pandoc_version() >= numeric_version("2"))
 
-source("utils.R")
+pptx_file <- tempfile(fileext = ".pptx")
+render_rmd("rmd/pptx.Rmd", output_file = pptx_file)
 
 
-test_that("visual testing tables", {
-  testthat::skip_if_not_installed("doconv")
-  testthat::skip_if_not(doconv::msoffice_available())
-  library(doconv)
-  pptx_file <- tempfile(fileext = ".pptx")
-  render_rmd("rmd/pptx.Rmd", output_file = pptx_file)
-  expect_snapshot_doc(x = pptx_file, name = "pptx-example", engine = "testthat")
-})
+test_that("find text in PowerPoint file", {
+  doc <- read_pptx(pptx_file)
+  all_doc_sum <- pptx_summary(doc)
+
+  doc_sum <- all_doc_sum[all_doc_sum$slide_id == 3,]
+  expect_contains(doc_sum$text, "temperature")
+  expect_contains(doc_sum$text, "pressure")
 
+  doc_sum <- all_doc_sum[all_doc_sum$slide_id == 4,]
+  expect_contains(doc_sum$text, "temperature")
+  expect_contains(doc_sum$text, "pressure")
+})