Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix altair and docs #32

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

ppeterlongotg
Copy link
Contributor

ciao @davidefiocco thanks for the great repo!

I just run it and found some minor issues:

I can split this PR if you want, but probably it would be an overkill.

I am adding a couple of screenshot here, maybe it could be nice to add them in the readme? I could do that in a follow up PR

image

image

@davidefiocco
Copy link
Owner

davidefiocco commented Jun 21, 2023

Ciao @ppeterlongotg ! :)

Thanks so much for spotting those issues and providing fixes! Changes look good to me!

I will remove also Heroku instructions in the README as per the docker-compose-related change (#30 related to this is pending still). Thank you very much!

@davidefiocco davidefiocco merged commit dade1d5 into davidefiocco:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants