Fix NativeClass not found exception #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davecoffin Could you please review and publish a new version to npm? The current version appears to be broken for all users since it didn't have ts-patch ran prior to publishing 😄 |
|
@davecoffin I would also appreciate if you merge this commit. The plugin is unusable at the moment... |
|
Sorry for the delay guys! Covid. Holidays. Fuck. |
|
sorry, 2.1.5 |
|
It's ok, we can understand how all 3 given reasons would be distracting 🤣 |
|
Thnx! |
|
Thank you! |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that ts-patch is run when npm run build is ran. This will make it impossible for the plugin to be published without having ts-patch ran which has caused #77
Once merged, doing a npm run clean & npm run build prior to publishing will fix #77