Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix, fixes error when modal closes without title #41

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Bugfix, fixes error when modal closes without title #41

merged 1 commit into from
Oct 22, 2018

Conversation

KevinBeckers
Copy link
Contributor

No description provided.

davecoffin
davecoffin approved these changes Oct 22, 2018
View reviewed changes
Copy link
Owner

@davecoffin davecoffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, if the PR is meant to be deployed, could you also increment the version in package.json so I can publish to npm without having to open up the project?

@davecoffin davecoffin merged commit 7c98861 into davecoffin:master Oct 22, 2018
@KevinBeckers
Copy link
Contributor Author

Yes, sure no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecoffin davecoffin davecoffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBeckers @davecoffin