fix duplicate db queries

datlechin · Dec 26, 2024 · fcec82c · fcec82c
1 parent a6490cf
commit fcec82c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/Concerns/HasLocationAction.php b/src/Concerns/HasLocationAction.php
@@ -13,6 +13,8 @@
 
 trait HasLocationAction
 {
+    protected ?Collection $menus = null;
+
     protected ?Collection $menuLocations = null;
 
     public function getLocationAction(): Action
@@ -70,7 +72,7 @@ public function getLocationAction(): Action
                             ->label(__('filament-menu-builder::menu-builder.actions.locations.form.menu.label'))
                             ->searchable()
                             ->hiddenLabel($key !== $this->getRegisteredLocations()->keys()->first())
-                            ->options($this->getModel()::all()->pluck('name', 'id')->all()),
+                            ->options($this->getMenus()->pluck('name', 'id')->all()),
                     ]),
             )->all() ?: [
                 Components\View::make('filament-tables::components.empty-state.index')
@@ -81,6 +83,11 @@ public function getLocationAction(): Action
             ]);
     }
 
+    protected function getMenus(): Collection
+    {
+        return $this->menus ??= FilamentMenuBuilderPlugin::get()->getMenuModel()::all();
+    }
+
     protected function getMenuLocations(): Collection
     {
         return $this->menuLocations ??= FilamentMenuBuilderPlugin::get()->getMenuLocationModel()::all();