Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added useTriggerFrame, useDeepEffect and useDeepMemo to exhaustive deps #113

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

dvmoritzschoefl
Copy link
Contributor

Proper eslint support for the custom hooks useTriggerFrame, useDeepEffect and useDeepMemo

@dvmoritzschoefl dvmoritzschoefl added the type: feature New feature or request label Jan 21, 2025
@dvmoritzschoefl dvmoritzschoefl requested a review from a team as a code owner January 21, 2025 08:19
@puehringer
Copy link
Contributor

@dvmoritzschoefl
Copy link
Contributor Author

@dvmoritzschoefl thanks for this, highly needed. Can you align it with https://github.com/datavisyn/visyn_scripts/pull/112/files#diff-fccd58693c6d7e858da9a6c6d93e6b2c134f4bd3326e7f985f820c0fb2f3af80R133-R135? 👍

Ah did not saw that you already added it. I used the same rules now.

@puehringer puehringer added the release: minor PR merge results in a new minor version label Jan 21, 2025
@puehringer puehringer merged commit 4afce4e into develop Jan 21, 2025
1 check passed
@puehringer puehringer deleted the mh/exhaustive_hooks branch January 21, 2025 10:10
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
puehringer added a commit that referenced this pull request Jan 21, 2025
## What's Changed
* feat: add ESLint playwright plugin by @oltionchampari in
#106
* update release.yaml for automated release workflow by @datavisyn-bot
in #102
* feat: Added useTriggerFrame, useDeepEffect and useDeepMemo to
exhaustive deps by @dvmoritzschoefl in
#113
* deps: rspack v1.1, TypeScript v5.7, ESLint v8, ... by @puehringer in
#112
* feat: rspack in storybook 8 by @puehringer in
#108

## New Contributors
* @datavisyn-bot made their first contribution in
#102
* @dvmoritzschoefl made their first contribution in
#113

**Full Changelog**:
v11.2.0...v12.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants