Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vis-type: bar): add tooltip to clipped axis labels #599

Merged
merged 8 commits into from
Oct 28, 2024
Merged

fix(vis-type: bar): add tooltip to clipped axis labels #599

merged 8 commits into from
Oct 28, 2024

Conversation

dv-usama-ansari
Copy link
Contributor

@dv-usama-ansari dv-usama-ansari commented Oct 28, 2024 •
edited
Loading

Coming from #596 (comment)

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified @dvdanielamoitzi @thinkh
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Add tooltip to the axis labels when the labels are clipped

Screenshots

bar-plot-axis-tooltip.webm

Additional notes for the reviewer(s)

  • The tooltip text is unfortunately not reactive because the handler function is not reinvoked when the config changes

@dv-usama-ansari dv-usama-ansari mentioned this pull request Oct 28, 2024
Merged
@dv-usama-ansari dv-usama-ansari marked this pull request as ready for review October 28, 2024 12:50
@dv-usama-ansari dv-usama-ansari requested a review from a team as a code owner October 28, 2024 12:50
@dv-usama-ansari dv-usama-ansari mentioned this pull request Oct 28, 2024
Open
Base automatically changed from dmoitzi/fix-barchart-grouping to develop October 28, 2024 13:54
dvdanielamoitzi
dvdanielamoitzi approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@dvdanielamoitzi dvdanielamoitzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the changes @dv-usama-ansari ! 👍

@dvdanielamoitzi dvdanielamoitzi changed the title fix: add tooltip to clipped axis labels fix(vis-type: bar): add tooltip to clipped axis labels Oct 28, 2024
@dvdanielamoitzi dvdanielamoitzi merged commit 02fecdf into develop Oct 28, 2024
9 of 11 checks passed
@dvdanielamoitzi dvdanielamoitzi deleted the ua/add-tooltip-to-clipping-axis-labels branch October 28, 2024 14:02
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Merged
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Merged
thinkh added a commit that referenced this pull request Nov 6, 2024
@thinkh
Release 14.2.0 (#623)
662fbb4 
## What's Changed
* fix(vis-type: bar): grouping with zero values by @dvdanielamoitzi in
#598
* fix(vis-type: bar): add tooltip to clipped axis labels by
@dv-usama-ansari in #599
* fix(vis-type: bar): selection is lost when bar plot is sorted by
@dv-usama-ansari in #604
* feat: use `FastTextMeasure` to get the truncated labels by
@dv-usama-ansari in #606
* fix(vis-type: bar): axis labels when sort state is null by
@dv-usama-ansari in #607
* fix: capturing a screenshot is broken for several visualizations by
@oltionchampari in #608
* feat(icon): Option for descending sort first + no unsorted state by
@dvdanielamoitzi in #609
* feat: Add `onClick` to `usePan` by @dvmoritzschoefl in
#619
* feat: add `get_default_redis_url()` by @dvviktordelev in
#610
* feat(vis-type: scatter): Add log scale option for axes by
@dvmoritzschoefl in #602
* fix: exports in general vis by @dvdanielamoitzi in
#621
* Added `useAnimatedTransform` hook by @dvmoritzschoefl in
#620
* Pinned @swc/core to 1.7.42 by @dvmoritzschoefl in
#622


**Full Changelog**:
v14.1.0...14.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdanielamoitzi dvdanielamoitzi dvdanielamoitzi approved these changes

@thinkh thinkh Awaiting requested review from thinkh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dv-usama-ansari @dvdanielamoitzi