Dev/robin/8859 simplehash schema v3 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2024 16:48
This new schema is required in order to ommit confirmation_status from the hash. For simplehash assets, this field was crucial. For forestrie it is only informative. And crucially, it changes after the event is first added to the log STORED -> COMMITTED -> CONFIRMED -> UNEQUIVOCAL We took the opportunity to prune other un-necessary fields: * asset_identity is redundant and will soon be confusing. * from is not relevant for forestrie (it was the custodial wallet address for khipu) Note that idtimestamp is NOT added. The details of the leaf hash construction are governed by forestrie and only change if the merkle log format version is incremented. And the database can't store the log values in native format anyway. Additionally, ci: enable code quality and unit tests on ci
honourfish
reviewed
Jan 24, 2024
honourfish
reviewed
Jan 24, 2024
honourfish
reviewed
Jan 24, 2024
| // format available to api consumers. The source event is in the grpc proto buf | ||
| // format. GRPC endpoints are not presently exposed by the platform. | ||
| // | ||
| // Options: |
robinbryce
force-pushed
the
dev/robin/8859-simplehash-schema-v3
branch
from
3699d2c to
e40de45
Compare
honourfish
reviewed
Jan 24, 2024
honourfish
approved these changes
Jan 24, 2024
Signed-off-by: Joe Gough <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: v3 schema for forestrie
This new schema is required in order to ommit confirmation_status from
the hash. For simplehash assets, this field was crucial. For forestrie
it is only informative. And crucially, it changes after the event is
first added to the log STORED -> COMMITTED -> CONFIRMED -> UNEQUIVOCAL
We took the opportunity to prune other un-necessary fields:
address for khipu)
Note that idtimestamp is NOT added. The details of the leaf hash
construction are governed by forestrie and only change if the merkle log
format version is incremented. And the database can't store the log
values in native format anyway.
Additionally,
ci: enable code quality and unit tests on ci