Automatically download Astra secure connect bundle #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that the cli flags could use some updating to be more use friendly and to separate Astra from OSS Cassandra.
mpenick
changed the title
|
Might need to rework because of changes in #71 |
|
Tested manually against an existing Astra cluster. I've created a follow up issue to add automated testing for this: #73 That will either mock out the Astra API or I will create an integration test with an existing Astra cluster in prod and have this run in CI with secrets. Maybe both? |
joao-r-reis
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new
--tokenand--database-idflags to allow the proxy to connect to Astra w/o having to provide a secure connect bundle file. This is much more user friendly and makes the k8s configuration more concise.Fixes: #47