Implement two new codecs STRING_BLOB and ASCII_BLOB
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration from `TEXT` and `ASCII` fields to `BLOB` fields
pravinbhat
requested review from
jeromatron,
Jeremya,
Ankitp1342 and
msmygit
msmygit
approved these changes
Sep 19, 2024
msmygit
reviewed
Sep 19, 2024
|
|
||
| @Test | ||
| public void encodeDecode() { | ||
| ByteBuffer buffer = codec.encode(ByteBuffer.wrap("Encode this Text string to Blob".getBytes()), |
There was a problem hiding this comment.
nitpick: should we extract Encode this Text string to Blob as a constant and re-use it everywhere?
msmygit
reviewed
Sep 19, 2024
| ByteBuffer buffer = codec.encode(ByteBuffer.wrap("Encode this Text string to Blob".getBytes()), | ||
| ProtocolVersion.V4); | ||
| ByteBuffer retBuffer = codec.decode(buffer, ProtocolVersion.V4); | ||
| assertEquals("'Encode this Text string to Blob'", codec.format(retBuffer)); |
There was a problem hiding this comment.
I see an extra single quotes surrounding this. Is this expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Implements two new codecs
STRING_BLOBandASCII_BLOBto allow migration fromTEXTandASCIIfields toBLOBfields.Which issue(s) this PR fixes:
Fixes #308
Checklist: