Implemented customTTL feature #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pravinbhat
requested review from
jeromatron,
Jeremya,
Ankitp1342 and
msmygit
msmygit
approved these changes
Sep 3, 2024
| protected static Long getCustomTTL(IPropertyHelper propertyHelper) { | ||
| Long cttl = propertyHelper.getLong(KnownProperties.TRANSFORM_CUSTOM_TTL); | ||
| return null == cttl ? 0L : cttl; | ||
| } |
There was a problem hiding this comment.
nitpick: formatting (indentation) looks incorrect here. could we get that fixed please?
There was a problem hiding this comment.
@msmygit The diff here is only the the way the space are formatted. Existing ones are spaces & the new ones are tabs. I will do a separate commit after this PR is merged to use consistent formatting in the whole repo & will also commit the styling config in the repo so all can use the same styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Implemented property
spark.cdm.transform.custom.ttlto allow a custom constant value to be set for TTL instead of using the values from origin rows.Which issue(s) this PR fixes:
Fixes #
Checklist: