fixing progress counter bug

[mieslep]

1. Consolidates progress logging into helper class JobCounter
2. Separates counts within each thread from the global counts
3. Increments global counts as each thread completes
4. Introduces new parameter to enable per-part logging
5. Per-part logging on a single line per part

Which issue(s) this PR fixes:
Fixes #196

Checklist:

• Automated Tests added/updated
• Documentation added/updated
• CLA Signed: DataStax CLA

[msmygit]

LGTM. Let's please coordinate with docs crew to publish this at https://docs.datastax.com/en/astra-serverless/docs/migrate/cassandra-data-migrator.html page

[msmygit]

I don't understand what we're doing in here by calling both true and false?

[mieslep]

Yeah that's a bit of an interesting choice, not entirely happy with it. false is for the thread itself, and I was trying to hide this messiness from the rest of the application. There are two kinds of progress counts, the existing printStatsAfter gives feedback as to how we are progressing within the global dataset, and then the new (and noisier) printStatsPerPart which prints an entry as each part completes.

    public void printProgress(boolean global) {
        if (global) {
            if (shouldPrintGlobalProgress()) {
                printAndLogProgress("Progress Counts: ", true);
            }
        } else {
            if (printPerThread) {
                printAndLogProgress("Thread Counts: ", false);
            }
        }
    }

[pravinbhat]

This should be just 2 separate methods (printGlobalProgress & printThreadProgess) to make it cleaner.

[pravinbhat]

OR remove the printProgress(boolean global) method completely & refactor the printProgress() method to something like below

    public void printProgress() {
        if (printPerThread) {
            printAndLogProgress("Thread Counts: ", false);
        }
        if (shouldPrintGlobalProgress()) {
            printAndLogProgress("Progress Counts: ", true);
        }
    }

[msmygit]

Any idea why we're receiving these ERRORs in the build output and how do we address them?

[mieslep]

@msmygit the ERROR log messages are being generated by junit tests which are probing for various conditions both positive and negative. I'm not sure how exactly to do this, but we could feasibly direct log output to a place other than console? I tried a few things to get it to work, but TBH the logging configuration on this seems messy enough (e.g. we have log4j exclusions in the pom.xml) and my Maven-foo is not strong.

[pravinbhat]

This should be just 2 separate methods (printGlobalProgress & printThreadProgess) to make it cleaner.

[pravinbhat]

OR remove the printProgress(boolean global) method completely & refactor the printProgress() method to something like below

    public void printProgress() {
        if (printPerThread) {
            printAndLogProgress("Thread Counts: ", false);
        }
        if (shouldPrintGlobalProgress()) {
            printAndLogProgress("Progress Counts: ", true);
        }
    }

[msmygit]

I've encorporated the review comments and pushed the changes. Merging here.