Skip to content
This repository has been archived by the owner on Oct 23, 2018. It is now read-only.

Mass upgrade #21

Merged
merged 39 commits into from
Jan 17, 2015
Merged

Mass upgrade #21

merged 39 commits into from
Jan 17, 2015

Conversation

PatrikStenmark
Copy link
Contributor

Upgrades:

  • Rails 3.0 -> 3.2
  • Rspec 2.6 -> 3.0
  • Devise 2 -> 3

And everything required for these upgrades.

This conversion is done by Transpec 3.0.7 with the following command:
    transpec

* 63 conversions
    from: obj.stub(:message)
      to: allow(obj).to receive(:message)

* 52 conversions
    from: obj.should
      to: expect(obj).to

* 24 conversions
    from: obj.should_not
      to: expect(obj).not_to

* 10 conversions
    from: obj.should_receive(:message)
      to: expect(obj).to receive(:message)

* 4 conversions
    from: == expected
      to: eq(expected)

* 3 conversions
    from: be_true
      to: be_truthy

* 2 conversions
    from: be_false
      to: be_falsey

* 2 conversions
    from: obj.should_not_receive(:message)
      to: expect(obj).not_to receive(:message)

* 1 conversion
    from: lambda { }.should
      to: expect { }.to

* 1 addition
      of: RSpec.configure { |c| c.infer_spec_type_from_file_location! }

For more details: https://github.com/yujinakayama/transpec#supported-conversions
For some reason, sprockets seem to hog AR connections when it fails.

Wtf?
PatrikStenmark and others added 9 commits January 15, 2015 23:05
When initializing a new `Reply` object, the `guest_state` field will be
conditionally set to `'unknown'` unless it was provided on initialization.
* Bump version
* Update initializer
  - add `secret_key`
  - load secrets from `.env`
* Make mailer views use `@token`
Set Reply#guest_state default in after_initialize
@PatrikStenmark PatrikStenmark changed the title Massuppgradering Mass upgrade Jan 17, 2015
Frost added a commit that referenced this pull request Jan 17, 2015
@Frost Frost merged commit a1466a5 into datasektionen:master Jan 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants