Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-143: Test compatibility with Python 3.10 and 3.11 #1146

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

ethho
Copy link
Contributor

@ethho ethho commented Dec 18, 2023

Add Python 3.10 and 3.11 to the CI strategy.matrix.py_ver.

Includes changes from #1141.

@ethho
Copy link
Contributor Author

ethho commented Dec 18, 2023

When using 3.10 or 3.11 with MySQL v5.7, PyMySQL is not able to connect, throwing the error in CI:

pymysql.err.OperationalError: (2003, "Can't connect to MySQL server on 'fakeservices.datajoint.io' ([SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:997))")

Next, I'll test 3.10 and 3.11 compatibility with only MySQL 8.0.

@ethho ethho requested a review from A-Baji December 20, 2023 14:20
@ethho ethho marked this pull request as ready for review December 20, 2023 14:20
@A-Baji
Copy link
Collaborator

A-Baji commented Jan 2, 2024

When using 3.10 or 3.11 with MySQL v5.7, PyMySQL is not able to connect, throwing the error in CI:

pymysql.err.OperationalError: (2003, "Can't connect to MySQL server on 'fakeservices.datajoint.io' ([SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:997))")

Next, I'll test 3.10 and 3.11 compatibility with only MySQL 8.0.

Is this something we want/ is worth fixing?

@ethho
Copy link
Contributor Author

ethho commented Jan 3, 2024

When using 3.10 or 3.11 with MySQL v5.7, PyMySQL is not able to connect, throwing the error in CI:

pymysql.err.OperationalError: (2003, "Can't connect to MySQL server on 'fakeservices.datajoint.io' ([SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:997))")

Is this something we want/ is worth fixing?

@A-Baji I spent some time this morning looking into this error. I documented some findings and partial fixes in #1149 and #1148. This appears to be out of scope for the nosetest migration, so let's deal with it in the separate issues I created.

@A-Baji A-Baji merged commit 73945d2 into datajoint:dev-tests Jan 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants