Add acceptance test for 'experimental.scripts' #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
andrewnester
approved these changes
Jan 27, 2025
| @@ -146,4 +146,8 @@ func AddHandlers(server *TestServer) { | |||
| }, | |||
| }, nil | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Why adding this call if deploy errors out anyway?
There was a problem hiding this comment.
It proceeds further with this call and executes more scripts.
| prebuild: "python3 ./myscript.py 0 prebuild" | ||
| postbuild: "python3 ./myscript.py 0 postbuild" | ||
| predeploy: "python3 ./myscript.py 0 predeploy" | ||
| postdeploy: "python3 ./myscript.py 0 postdeploy" |
There was a problem hiding this comment.
We don't really test this one, correct? Should we have an integration test instead which does successful deploy so we can cover this as well?
There was a problem hiding this comment.
It is useful to have it there to see that it was not run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.