Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceptance/selftest, showcasing basic features #2229

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Add acceptance/selftest, showcasing basic features #2229

merged 8 commits into from
Jan 27, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 24, 2025

Also make TestInprocessMode use this test.

@denik
Add acceptance/selftest, showcasing basic features
6c36893 
Make TestInprocessMode use this test.
@denik denik temporarily deployed to test-trigger-is January 24, 2025 16:29 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 24, 2025 17:20 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 24, 2025 17:25 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 24, 2025 17:31 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 24, 2025 17:39 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 24, 2025 18:49 — with GitHub Actions Inactive
@denik denik enabled auto-merge January 24, 2025 19:23
@pietern pietern disabled auto-merge January 27, 2025 07:49
pietern
pietern approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update acceptance/README.md to point at this?

It would be nice to include custom test configuration as well.

@denik denik temporarily deployed to test-trigger-is January 27, 2025 07:56 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 27, 2025 08:01 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 27, 2025 08:03 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 27, 2025 08:08 — with GitHub Actions Inactive
@denik
Copy link
Contributor Author

denik commented Jan 27, 2025

Can you update acceptance/README.md to point at this?

Updated

It would be nice to include custom test configuration as well.

I've added test.toml with all supported fields (commented out), would be good to use this also as a demo of test.toml.

@denik denik enabled auto-merge January 27, 2025 08:11
@denik denik disabled auto-merge January 27, 2025 08:17
@denik denik merged commit 82b0dd3 into main Jan 27, 2025
8 of 9 checks passed
@denik denik deleted the denik/selftest branch January 27, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denik @pietern