fix: pass keys to column optimisation
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
commented
Dec 2, 2023
douglasdavis
reviewed
Dec 5, 2023
douglasdavis
force-pushed
the
agoose77/fix-compute-leaves
branch
from
ddd0237 to
f565a71
Compare
douglasdavis
force-pushed
the
agoose77/fix-compute-leaves
branch
from
f565a71 to
18b5c7b
Compare
|
Alright this is getting close. It fixes #426 which was the goal. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 93.10% 93.08% -0.03%
==========================================
Files 23 23
Lines 3279 3283 +4
==========================================
+ Hits 3053 3056 +3
- Misses 226 227 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@douglasdavis I think this fixes #426.
However, I changed the type hints and made a subtle change to appease the type checker. I'm not convinced it's correct and would appreciate your input. I'll tag you at the edit site.
In our tests we assume that we can pass in
keys=[]. Is that supposed to be the way thatdask.optimizeis used?