Skip to content

Commit

Permalink
Add explicit indicators for diagnostics that are missing documentation
Browse files Browse the repository at this point in the history
I believe that this will make it easier to identify which diagnostics
are undocumented (though I haven't done this for parser-produced
diagnostics). It will also allow us to easily count how many there are
in order to monitor progress / regress.

I also normalized the location of the flag to make the file a little
cleaner.

Change-Id: I4fe07f446508788a8c02efcd8e78e94689ffb40b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365283
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
  • Loading branch information
bwilkerson authored and Commit Queue committed May 6, 2024
1 parent 95d96cf commit 549cc20
Show file tree
Hide file tree
Showing 2 changed files with 220 additions and 74 deletions.
6 changes: 3 additions & 3 deletions pkg/analyzer/lib/src/error/codes.g.dart
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
'AUGMENTATION_WITHOUT_LIBRARY',
"The URI does not resolve to a library.",
correctionMessage:
"Try updating the URI to reference the augmented library",
"Try updating the URI to reference the augmented library.",
);

/// No parameters.
Expand Down Expand Up @@ -2128,10 +2128,10 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
static const CompileTimeErrorCode GENERIC_FUNCTION_TYPE_CANNOT_BE_BOUND =
CompileTimeErrorCode(
'GENERIC_FUNCTION_TYPE_CANNOT_BE_BOUND',
"Generic function types can't be used as type parameter bounds",
"Generic function types can't be used as type parameter bounds.",
correctionMessage:
"Try making the free variable in the function type part of the larger "
"declaration signature",
"declaration signature.",
);

/// It is a compile-time error if a generic function type is used as an actual
Expand Down
Loading

0 comments on commit 549cc20

Please sign in to comment.