Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove package:http from package:intl #928

Merged
merged 1 commit into from
Jan 2, 2025
Merged

remove package:http from package:intl #928

merged 1 commit into from
Jan 2, 2025

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Dec 19, 2024

  • remove package:http from package:intl
  • run dart pub run downgrade --tighten

This uses fetch from package:web directly instead of using package:http. This works in this case - the library in question (lib/src/http_request_data_reader.dart) is only ever called from the browser.

This PR moves the package to a -wip version; we'll likely want to follow this up with a PR looking to in-line uses of package:web (assuming that that's a tractable amount of code).


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl Non-Breaking 0.20.1 0.20.2-wip 0.20.2 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/intl/lib/date_symbol_data_http_request.dart 💔 Not covered
pkgs/intl/lib/src/http_request_data_reader.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
intl StringStack
DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@kevmoo kevmoo changed the title remote package:http from package:intl remove package:http from package:intl Dec 19, 2024
@devoncarew devoncarew merged commit d47173b into main Jan 2, 2025
14 checks passed
@devoncarew devoncarew deleted the remove_http branch January 2, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants