Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking to fetch the libraries from Github #877

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Aug 21, 2024

Fix the links and hashes, together with some minor fixes.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Aug 21, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:intl4x 0.10.1 ready to publish intl4x-v0.10.1
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Aug 21, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl4x None 0.10.0 0.10.1 0.10.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/intl4x/hook/build.dart 💔 Not covered
pkgs/intl4x/lib/src/hook_helpers/hashes.dart 💔 Not covered
pkgs/intl4x/lib/src/hook_helpers/version.dart 💔 Not covered
pkgs/intl4x/tool/regenerate_hashes.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️
Package Version Status
package:intl4x 0.10.1 ready to publish
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 22, 2024
@mosuem mosuem marked this pull request as ready for review August 22, 2024 10:48
@mosuem mosuem requested a review from robertbastian August 22, 2024 10:48
@mosuem mosuem merged commit 4796ea1 into main Aug 22, 2024
22 checks passed
@mosuem mosuem deleted the fetchDyLibsOnly branch August 22, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x publish-ignore-warnings type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants