Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip symbols manually #862

Closed
wants to merge 6 commits into from
Closed

Strip symbols manually #862

wants to merge 6 commits into from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Aug 5, 2024

Run link.dart with a static library and a manually curated list of symbols when building in AOT mode.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Aug 5, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
intl4x Non-Breaking 0.9.2-wip 0.9.2-wip 0.9.2-wip ✔️

Changelog Entry ❗

Details
Package Changed Files
package:intl4x pkgs/intl4x/example_native/README.md
pkgs/intl4x/example_native/pubspec.yaml
pkgs/intl4x/example_web/README.md
pkgs/intl4x/example_web/pubspec.yaml
pkgs/intl4x/lib/src/locale/locale_native.dart
pkgs/intl4x/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️

Details
File Coverage
pkgs/intl4x/example_native/bin/example_native.dart 💔 Not covered
pkgs/intl4x/example_web/web/main.dart 💔 Not covered
pkgs/intl4x/hook/build.dart 💔 Not covered
pkgs/intl4x/hook/link.dart 💔 Not covered
pkgs/intl4x/hook/shared.dart 💔 Not covered
pkgs/intl4x/lib/src/locale/locale_native.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ⚠️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/intl4x/example_native/bin/example_native.dart

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

Package publish validation ✔️

Details
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.9.2-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 6, 2024
@mosuem mosuem closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant