-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookie banner #3097
Add cookie banner #3097
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Thanks for sending a pull request - I tested this locally and deployed this to https://sketch-pad-1cebb--cookie-banner-bvpssvbh.web.app, but I'm not seeing the cookie banner. cc/ @devoncarew I remember you mentioning there were some technical issues you noticed when you tried to add this feature? |
I was not able to see the banner when I tried this myself, a few months ago. If I remember correctly, I think that the flutter content was always full screen - the banner didn't have any height, or was obscured? Perhaps I was missing something, or the banner has some other check that wasn't triggering. From the screenshot @mit-mit was able to get it working. |
I think this is because I am in the US.
|
Correct, the banner is geo-coded to only display in eligible regions. Googlers can use go/polyjuice-extension to test the behavior in other regions than their physical one. |
@johnpryan can you try to test with that and confirm that its working on your end on your staged site? If so, please go ahead and merge. |
LGTM |
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.