Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_detect: bump lints and SDK versions #713

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/os_detect.yaml
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@ jobs:
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
os: [ubuntu-latest, windows-latest, macos-latest]
sdk: [3.0.0, dev]
sdk: [3.5, dev]
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
- uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
2 changes: 0 additions & 2 deletions pkgs/args/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -10,5 +10,3 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- unnecessary_await_in_return
2 changes: 1 addition & 1 deletion pkgs/args/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -13,4 +13,4 @@ environment:

dev_dependencies:
dart_flutter_team_lints: ^3.0.0
test: ^1.16.0
test: ^1.16.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why the increase in specificity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what dart pub upgrade --tighten does 🤷

1 change: 0 additions & 1 deletion pkgs/async/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -18,4 +18,3 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
1 change: 0 additions & 1 deletion pkgs/collection/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -12,5 +12,4 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- unnecessary_await_in_return
2 changes: 1 addition & 1 deletion pkgs/collection/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -13,4 +13,4 @@ environment:

dev_dependencies:
dart_flutter_team_lints: ^3.0.0
test: ^1.16.0
test: ^1.16.6
1 change: 0 additions & 1 deletion pkgs/convert/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- unnecessary_await_in_return
1 change: 0 additions & 1 deletion pkgs/crypto/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -10,4 +10,3 @@ linter:
rules:
- avoid_unused_constructor_parameters
- cancel_subscriptions
- package_api_docs
1 change: 0 additions & 1 deletion pkgs/fixnum/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -14,7 +14,6 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- unnecessary_raw_strings
1 change: 0 additions & 1 deletion pkgs/logging/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -20,7 +20,6 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_locals
2 changes: 1 addition & 1 deletion pkgs/logging/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -14,4 +14,4 @@ environment:

dev_dependencies:
dart_flutter_team_lints: ^3.0.0
test: ^1.16.0
test: ^1.16.6
4 changes: 4 additions & 0 deletions pkgs/os_detect/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.3-wip

- Require Dart 3.5

## 2.0.2

- Require Dart 3.0
1 change: 0 additions & 1 deletion pkgs/os_detect/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -20,7 +20,6 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- use_raw_strings

2 changes: 1 addition & 1 deletion pkgs/os_detect/bin/os_detect.dart
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

/// Prints the operating system detected by the current compilation environment.
library pkg.os_detect.run;
library;

import 'package:os_detect/os_detect.dart' as os_detect;

2 changes: 1 addition & 1 deletion pkgs/os_detect/lib/os_detect.dart
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

/// Information about the current operating system.
library pkg.os_detect;
library;

import 'src/os_override.dart';

6 changes: 3 additions & 3 deletions pkgs/os_detect/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
name: os_detect
version: 2.0.2
version: 2.0.3-wip
description: Platform independent OS detection.
repository: https://github.com/dart-lang/core/tree/main/pkgs/os_detect

environment:
sdk: ^3.0.0
sdk: ^3.5.0

dependencies:
meta: ^1.9.0

dev_dependencies:
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.0.0
test: ^1.24.0
1 change: 0 additions & 1 deletion pkgs/path/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -9,7 +9,6 @@ linter:
- join_return_with_assignment
- missing_whitespace_between_adjacent_strings
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_locals
2 changes: 1 addition & 1 deletion pkgs/platform/example/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -11,4 +11,4 @@ dependencies:
path: ../

dev_dependencies:
lints: ^4.0.0
lints: ^5.0.0
1 change: 0 additions & 1 deletion pkgs/typed_data/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -10,4 +10,3 @@ linter:
- avoid_unused_constructor_parameters
- cancel_subscriptions
- no_adjacent_strings_in_list
- package_api_docs