Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sony ILCE-7CM2 support #528

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Oct 10, 2023

Confirmed as a copy of 7M4 by ADC 16.0

@kmilos kmilos requested a review from LebedevRI as a code owner October 10, 2023 16:11
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c1902a) 59.08% compared to head (0723e2b) 59.08%.
Report is 23 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #528   +/-   ##
========================================
  Coverage    59.08%   59.08%           
========================================
  Files          232      232           
  Lines        13903    13903           
  Branches      1939     1939           
========================================
  Hits          8214     8214           
  Misses        5556     5556           
  Partials       133      133           
Flag Coverage Δ
benchmarks 8.17% <ø> (ø)
integration 47.49% <ø> (ø)
linux 57.00% <ø> (ø)
macOS 18.67% <ø> (ø)
rpu_u 47.49% <ø> (ø)
unittests 18.22% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LebedevRI
Copy link
Member

There are zero samples for ILCE-7CR on RPU.
Can you please split that into a separate PR?

@kmilos kmilos force-pushed the kmilos/sony_a7cm2+a7cr branch from bfbbce5 to 0723e2b Compare October 10, 2023 17:57
@kmilos kmilos changed the title Sony ILCE-7CM2 and ILCE-7CR support Sony ILCE-7CM2 support Oct 10, 2023
@kmilos
Copy link
Collaborator Author

kmilos commented Oct 10, 2023

Can you please split that into a separate PR?

Done. I'll push the other one later.

@kmilos
Copy link
Collaborator Author

kmilos commented Oct 11, 2023

The APS-C crop is not ideal, but I suggest we go w/ the FF value just as for the 7M4 for now.

@kmilos
Copy link
Collaborator Author

kmilos commented Oct 25, 2023

@LebedevRI Can we merge this as is please so I can push a 7CR one? Any extra crop related codebase work will obviously have to come separately and handle 7M4 and 7CM2 at the same time...

@LebedevRI
Copy link
Member

@LebedevRI Can we merge this as is please so I can push a 7CR one? Any extra crop related codebase work will obviously have to come separately and handle 7M4 and 7CM2 at the same time...

Sorry, i meant to merge this right after the PR was split. I'll merge today.

@LebedevRI
Copy link
Member

@kmilos thank you.

@LebedevRI LebedevRI merged commit 42a77b8 into darktable-org:develop Nov 1, 2023
2 checks passed
@kmilos kmilos deleted the kmilos/sony_a7cm2+a7cr branch November 1, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

2 participants