Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picking 42a99c2 into release branch #1135

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

alicejgibbons
Copy link

@alicejgibbons alicejgibbons commented Jan 18, 2025

Description

Cherry picking the python sdk crypto quickstart into the 1.15 release branch.

Issue reference

PR: #1093
Issue for master: #1052

Please reference the issue this PR will close: #1052

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please have one clean PR for Jobs (this one?) and one for Crypto in Python? Sorry for extra work but this keeps the churn down and helps us protect the tests.

cryptography/python/sdk/README.md Show resolved Hide resolved
cryptography/python/sdk/crypto-quickstart/desert.jpg Outdated Show resolved Hide resolved
@paulyuk
Copy link
Contributor

paulyuk commented Jan 20, 2025

Also let me know if you need help getting tests to pass again in this branch. I think it's pointing to unexpected deprecation warnings.

@alicejgibbons alicejgibbons changed the title Dotnet HTTP Jobs Quickstart Cherry picking 42a99c2 into release branch Jan 20, 2025
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: Alice Gibbons <[email protected]>
Copy link
Contributor

@rochabr rochabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verbiage changes

cryptography/python/sdk/README.md Show resolved Hide resolved
@alicejgibbons
Copy link
Author

Resolved the comments for the python sdk crypto quickstart since this has already been merged in #1093 to master. This just needs to be merged into 1.15 release branch

@alicejgibbons alicejgibbons requested a review from paulyuk January 21, 2025 18:14
@mikeee mikeee mentioned this pull request Jan 22, 2025
4 tasks
@paulyuk paulyuk merged commit 8d2c7ab into dapr:release-1.15 Jan 22, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants