[LDE: Project] 'Codegen-only compilation pipeline for LA operations' #935
Conversation
containers/entrypoint-interactive.sh
Outdated
There was a problem hiding this comment.
Remove these changes.
containers/run-docker-example.sh
Outdated
There was a problem hiding this comment.
Remove these changes.
scripts/examples/slice.daph
Outdated
There was a problem hiding this comment.
Remove this file and add proper testcases. Look at the testcases in test/codegen/ and test/api/cli/codegen, there you will find different kind of tests for our codegen. FileCheck based tests that verify the IR after a certain pass(es), and end-to-end tests that execute daphne and verify the output. You should add a single file, e.g., test/codegen/sliceop.mlir for the IR tests and a single .cpp file for the end-to-end tests that compare the non codegen with the codegen'd execution of daphne.
There was a problem hiding this comment.
Combine these into a single pass which has two rewrite patterns.
| SmallVector<AffineMap, 2> indexMaps{AffineMap::getMultiDimIdentityMap(2, rewriter.getContext()), | ||
| AffineMap::getMultiDimIdentityMap(2, rewriter.getContext())}; | ||
|
|
||
| SmallVector<utils::IteratorType, 2> iterTypes{utils::IteratorType::parallel, | ||
| utils::IteratorType::parallel}; | ||
|
|
||
| rewriter.create<linalg::GenericOp>(loc, TypeRange{}, ValueRange{selMemref}, ValueRange{resMemref}, | ||
| indexMaps, iterTypes, | ||
| [&](OpBuilder &OpBuilderNested, Location locNested, ValueRange arg) { | ||
| OpBuilderNested.create<linalg::YieldOp>(locNested, arg[0]); | ||
| }); |
There was a problem hiding this comment.
This shouldn't be needed, as we want to create a view of a matrix we don't want to copy the data. The memref::SubViewOp should be enough. You'll need to properly lower it afterwards by adding the following passes to the pipeline:
mlir::memref::createExpandStridedMetadataPass; and mlir::createFinalizeMemRefToLLVMConversionPass.
This is an implementation of Codegen-only compilation pipeline for LA operations #693 as the coursework for 'LDE: Project'