Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for emoji inside messages markdown #5384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thingersoft
Copy link
Contributor

Summary

Introduces the remark-emoji plugin to properly render emoji inside chat messages.

Closes #5382

Change Type

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@thingersoft thingersoft force-pushed the markdown-emoji-support branch from 20d815a to 709f89c Compare January 21, 2025 03:12
@thingersoft thingersoft force-pushed the markdown-emoji-support branch from 709f89c to 358c4ac Compare January 21, 2025 19:11
@thingersoft thingersoft force-pushed the markdown-emoji-support branch from 358c4ac to 48cc07e Compare January 21, 2025 19:51
@thingersoft
Copy link
Contributor Author

thingersoft commented Jan 21, 2025

Please organize the imports from shortest line to longest, as they were before

Hello Danny,
first time I hear about such an import sorting criteria onestly 😅
What's the reason behind this choice, don't know about any IDE supporting it either.
Anyway I disabled automatic imports organization and reverted to previous ordering, should be ok now.

@danny-avila
Copy link
Owner

Hello Danny, first time I hear about such an import sorting criteria onestly 😅 What's the reason behind this choice, don't know about and IDE supporting it either. Anyway I disabled automatic imports organization and reverted to previous ordering, should be ok now.

It's my personal preference, it helps me keep imports organized by some logic. Ascending line length for packages, and descending for types and local modules

Thank you I applied changes too.

@thingersoft
Copy link
Contributor Author

It's my personal preference, it helps me keep imports organized by some logic. Ascending line length for packages, and descending for types and local modules

Ok, I understand everyone has personal taste about code formatting but when there aren't tools supporting that style it becomes hard to enforce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: add support for emoji inside messages markdown
2 participants