Handle EOF on stdin better #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankamongmen
force-pushed
the
dankamongmen/fucking-input
branch
from
b459af7 to
46a062f
Compare
dankamongmen
force-pushed
the
dankamongmen/fucking-input
branch
3 times, most recently
from
3e475ff to
2bb645c
Compare
When we get to the EOF on stdin, we need account for that with the readiness fd. Post to it upon the EOF transition. Closes #2525.
dankamongmen
force-pushed
the
dankamongmen/fucking-input
branch
from
b9b2f8b to
89a7eb0
Compare
dankamongmen
force-pushed
the
dankamongmen/fucking-input
branch
from
89a7eb0 to
6997c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we've received EOF on stdin, stop adding new input to the user queue. This input could come from e.g. a keyboard attached to the terminal when input is redirected from some file. After seeing
NCKEY_EOF, the user ought see no new input.Account for the EOF event by posting to the readiness file descriptor provided to the user. Closes #2525.
Don't use
sigaltstack()when built with ASAN stupport; they're incompatible. Closes #2529.Track EOF in
ncdirectand interpret Ctrl+'d' as EOF. Closes #2521.