Support glob paths in schema #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! I will give it a closer look as soon as I am able to. ❤️ |
|
This is awesome. Really appreciate you taking the time to write a test for it as well. Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2024
## [3.4.0](v3.3.8...v3.4.0) (2024-11-23) ### Features * support glob paths in schema ([#33](#33)) ([2efef2e](2efef2e)), closes [#34](#34) ### Continuous Integration * update github action versions ([0c656ab](0c656ab)) ### Miscellaneous Chores * update node to `v22.11.0` lts ([d941f32](d941f32)) * use `.node-version` file ([863a61a](863a61a))
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I work on a project and we have many schema files, which we are collecting using glob, e.g.
src/server/**/*.graphql.After saving those files the watch mode codegen process does not start.
Solution
To solve this problem we can use
loadSchemafunction which works asloadDocumentsfunction. It takes array of paths and glob-patterns and returns array of normalized file paths.We use this paths to match changed files.
Notes
Function
loadSchemahave a bug with typings. In the type definition says that it accepts only one schema pointer. But function use another module which supports array of schema pointers too.I have created an issue to @graphql-codegen/cli - dotansimha/graphql-code-generator#10196