Set _attr_unique_id on AttractionSensor #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes AttractionSensor entities to also set the _attr_unique_id value to a formatted string that combines the config entry ID and the attraction ID. The config entry ID is included to ensure that multiple config entries for the same park or different config entries with the same attraction IDs don't clash with each other.
|
Thanks @bkeiren - I've merged and cut a new release - I think that makes it show up in HACS, please give it a go and let me know if it's done what you need. |
|
@danielsmith-eu I can confirm this now works in the latest release, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes
AttractionSensorentities to also set the_attr_unique_idvalue to a formatted string that combines the config entry ID and the attraction ID. The config entry ID is included to ensure that multiple config entries for the same park or different config entries with the same attraction IDs don't clash with each other.This partially solves the issue in #12 by having the entities be shown as part of the integration. They are not yet linked to the device.