Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix dump one of fields #652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aymen-k
Copy link

@aymen-k aymen-k commented Dec 19, 2024

Summary

Hey 👋
I generated code with pydantic validation.
A nested class failed the validation. For some reason, the object is validated twice once with the initialized object and once with empty fields.

    @model_validator(mode="after")
    def check_oneof(cls, values):
        return cls._validate_field_groups(values)

Switching the order of the condition made it possible to avoid the second 'extra' validation.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Gobot1234
Copy link
Collaborator

Hi there, what does this fix? Please can you add a regression test

@aymen-k
Copy link
Author

aymen-k commented Dec 19, 2024

Hi @Gobot1234, just added description to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants