Options no_ignore, no_ignore_parent, hidden and follow #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilan-schemoul
force-pushed
the
main
branch
3 times, most recently
from
4015a9f to
4a8861d
Compare
These four options are brought from the find_files finder of Telescope. Default option for no_ignore is false therefore unlike the current behaviour all files from .gitignore will be ignored (as it is always done with Telescope and massively improve performance)
|
Apologies for the late response. I am reluctant to add a bunch of options for several reasons. It adds complexity, makes testing difficult due to all the different option combinations, it makes the docs more daunting, etc. With that said, if the default rg options aren't suitable, I think it would be better just do have an |
danielfalk
reviewed
Oct 15, 2024
|
|
||
| For files not already in your history, smart-open uses ripgrep for scanning the current directory. (The command is roughly: `rg --files --glob-case-insensitive --hidden --ignore-file=<cwd>/.ff-ignore -g <ignore_patterns...>`). | ||
|
|
||
| As a result, files added to git, _but also ignored by git_, will not be included. While not common, this is something that git allows. If this becomes a problem you can work around it by either changing your git ignore patterns, editing the file in neovim in some other way, (thereby adding it to the history), or by using ripgrep's `.ignore` file for overriding git. |
There was a problem hiding this comment.
afaik, this is still a limitation. Ripgrep will not list a file that is added to git if it also matches a .gitignore pattern. (I believe git ls-files does the right thing here, and would list such files.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options no_ignore, no_ignore_parent, hidden and follow
These four options are brought from the find_files finder of Telescope.
Default option for no_ignore is false therefore unlike the current behaviour
all files from .gitignore will be ignored (as it is always done with Telescope
and massively improve performance)