Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert full line comments - fixes #73 #75

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

daniel-sc
Copy link
Owner

No description provided.

@daniel-sc daniel-sc self-assigned this Jan 20, 2025
@daniel-sc
Copy link
Owner Author

@rburkey2005 would you like to check the preview https://deploy-preview-75--bash-converter.netlify.app/ if this works for your cases as expected?

@rburkey2005
Copy link

Yes, it's very nice, and will save a lot of time cutting-and-pasting comments from the shell script into the batch file for anybody so-inclined to do so!

My only other observation: I hadn't thought about when I wrote the original issue, but now that I see the result it does occur to me that a very-similar mechanism could be used to preserve blank lines, and that that would improve the readability/understandability/maintainability of the batch file being produced. (At least in the kinds of scripts I write 😄.)

@daniel-sc
Copy link
Owner Author

@rburkey2005 ok - actually the same thing crossed my mind, so here we go: https://deploy-preview-75--bash-converter.netlify.app/ :)

@rburkey2005
Copy link

It seems mighty fine to me. Great job!

@daniel-sc daniel-sc merged commit a82cfae into master Jan 20, 2025
7 checks passed
@daniel-sc daniel-sc deleted the 73-convert-full-line-comments branch January 20, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants