Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failsafe etelemetry import #1399

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Failsafe etelemetry import #1399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dandi/files/bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
from dandischema.models import BareAsset, CommonModel
from dandischema.models import Dandiset as DandisetMeta
from dandischema.models import get_schema_version
from etelemetry import get_project
from packaging.version import Version
from pydantic import ValidationError
import requests
Expand Down Expand Up @@ -737,6 +736,8 @@
_current_nwbinspector_version = get_package_version(name="nwbinspector")
# Ensure latest version of NWB Inspector is installed and used client-side
try:
from etelemetry import get_project

Check warning on line 739 in dandi/files/bases.py

View check run for this annotation

Codecov / codecov/patch

dandi/files/bases.py#L739 

Added line #L739 was not covered by tests

max_version = Version(
get_project(repo="NeurodataWithoutBorders/nwbinspector")["version"]
)
Expand Down
Loading